From 26fffcfdbaa23def1d2ed0a15e53ed7907883083 Mon Sep 17 00:00:00 2001 From: Jan Date: Thu, 20 Jun 2024 16:42:17 +0200 Subject: Remove invalid memset in ServerPresence (#709) The use of sizeof is incorrect here since `this` is a pointer and sizeof is used on the pointer directly, instead of what the pointer points to. It seems to work without issue due to padding but could cause issues if an instanced class like `std::string` gets nulled. --- primedev/server/serverpresence.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/primedev/server/serverpresence.h b/primedev/server/serverpresence.h index 94ecfe6a..07c6fb55 100644 --- a/primedev/server/serverpresence.h +++ b/primedev/server/serverpresence.h @@ -19,10 +19,7 @@ public: int m_iPlayerCount; int m_iMaxPlayers; - ServerPresence() - { - memset(this, 0, sizeof(this)); - } + ServerPresence() {} ServerPresence(const ServerPresence* obj) { -- cgit v1.2.3